Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Re-enable subgroup shuffle_fp64 test for CUDA #1663

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[SYCL][CUDA] Re-enable subgroup shuffle_fp64 test for CUDA #1663

merged 1 commit into from
Mar 24, 2023

Conversation

@GeorgeWeb
Copy link

@GeorgeWeb GeorgeWeb commented Mar 15, 2023 •
edited
Loading

The SYCL/SubGroup/shuffle_fp64.cpp test was failing (originally reported in intel/llvm/issues/8516) due to a compilation issue resolved in intel/llvm/pull/8614.

This PR re-enables the test now that the fix has been merged.

@GeorgeWeb GeorgeWeb requested review from a team and Pennycook as code owners March 15, 2023 14:46
@GeorgeWeb GeorgeWeb requested a review from steffenlarsen March 15, 2023 14:46
@cperkinsintel
Copy link 

Failed Tests (2):
[2023-03-15T15:19:19.920Z]   SYCL :: InvokeSimd/Spec/ImplicitSubgroup/simd_mask.cpp
[2023-03-15T15:19:19.920Z]   SYCL :: InvokeSimd/Spec/simd_mask.cpp

These failures are unrelated to this PR and are known and being tracked.

@GeorgeWeb
Copy link
Author

Note: Only rebased and force-pushed so I can re-trigger the CI which seemed to fail strangely on the first job.

@steffenlarsen
Copy link

Note: Only rebased and force-pushed so I can re-trigger the CI which seemed to fail strangely on the first job.

Alternative options for future reference:

  1. git merge name_of_remote/intel and push the resulting merge commit. This should not need a forced push.
  2. Close and reopen the PR. This should retrigger CI.

@againull againull merged commit 2b11eb1 into intel:intel Mar 24, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@GeorgeWeb
[SYCL][CUDA] Re-enable subgroup shuffle_fp64 test for CUDA (intel/llv…
f7a7b69 
…m-test-suite#1663)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Pennycook Pennycook Awaiting requested review from Pennycook Pennycook is a code owner

1 more reviewer

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GeorgeWeb @cperkinsintel @steffenlarsen @againull